styles: parameter and return type tweaks #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be used for styling the type for clarity
|
|
|
@toddjordan should we change the return type text color to something brighter? |
|
I was going to do a dark orange, but the links are almost the same color. If links had underlines, we could do that. |
|
@knownasilya may be increase the font weight to begin with? |
|
Of the type or the link? |
|
The return type. |
Gaurav0
pushed a commit
to Gaurav0/ember-api-docs
that referenced
this pull request
Sep 16, 2019
Update dependency-injection.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it more obvious where the type ends and the description begins. I didn't check this locally.
Looks something like this: