WIP bugfix: hide private API when following guides/legacy links (#307)

[jenweber]

WIP don't merge.

Addresses #307

Based on conversation about hiding private API by default (#303), I think it makes sense that legacy urls should not show private api by default either.

Currently, links from the Guides redirect to showing all QPs (inherited, protected, private, deprecated), so new learners would see private API a lot. I fixed this by changing the legacy url processing.

[toddjordan]

This would kill people's bookmarks

[jenweber]

@toddjordan because people have bookmarks that include the QPs? I'll read this a little more closely and see if I can account for those.

[toddjordan]

Yes people have bookmarks to private things. I guess it's a question of whether to support it

[jenweber]

Broken links are the worst. I didn't really think it through all the way, just saw that legacy links get all the boxes checked and that the Guides are linking people to private APIs. I'll give it another shot. I think I can JavaScript my way through supporting both.

[toddjordan]

Yeah. Agreed it's confusing linking from guides. We should def. convert thing guide links to the new URL structure

[jenweber]

@toddjordan I think maybe this fixes it? Let me know your thoughts.

As of my latest commit:

• if you have an old link that goes to something private, deprecated, or protected, you will see those QP in your redirect (and only those, so if you have a "private" QP and no others, you will only see only private API box checked)
• if you have an old link with no QP specified, you will see only inherited by default (even if no inherited methods are available or you were linking to private API)

Examples:
Legacy link with hash & QP: http://localhost:4200/classes/Ember.Router.html?show=private#method_map
Redirects to: https://emberjs.com/api/ember/2.15.0/classes/Ember.Router/methods/map?anchor=map&show=private
Shows: only private API is checked.

Legacy hashed link without QP: http://localhost:4200/classes/Ember.Router.html?e#method_map
Redirects to: http://localhost:4200/ember/2.15.0/classes/Ember.Router/methods/map?anchor=map
Shows: Only inherited is checked via fallback to application wide defaults.

Legacy links without a hash or QP: http://localhost:4200/classes/String.html
Redirects to: http://localhost:4200/ember/2.15.0/classes/String
Shows: Only inherited is checked via fallback to application wide defaults. Since String has only private methods, none are shown by default.

Legacy links with QP and without a hash: http://localhost:4200/classes/String.html?show=private
Redirects to http://localhost:4200/ember/2.15.0/classes/String?show=private
Shows: Only private is checked.

Legacy private API links with private QP: http://localhost:4200/classes/Ember.Router.html?show=private#method__deserializeQueryParam
Redirects to http://localhost:4200/ember/2.15.0/classes/Ember.Router/methods/_deserializeQueryParam?anchor=_deserializeQueryParam&show=private
Shows: Only private is checked.

Legacy private API links missing QP: http://localhost:4200/classes/Ember.Router.html#method__deserializeQueryParam
Redirects to http://localhost:4200/ember/2.15.0/classes/Ember.Router/methods/_deserializeQueryParam?anchor=_deserializeQueryParam
Shows: Only inherited is checked via fallback to application wide defaults. Does not show specified private method!

[jenweber]

@toddjordan I also experimentally tried to fix #340 so let me know if you want me to remove that change & squash the commits but I just undid that & squashed, since it seems like being on node v8 is important.

[jenweber]

I just realized I am making the assumption that the old API site used QPs and they were named the same. Is that true?

[jenweber]

I'm just going to close this and do something totally different after the links have settled. It's partially irrelevant from replacing all the links in 2.16 guides