Skip to content

[BUGFIX] Create anchor for “Properties” tab items #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ynotdraw
Copy link

@ynotdraw ynotdraw commented Oct 1, 2018

Fixes #546. It appears the class-field-description component was just missing an action on-click.

  • Created an acceptance test for "anchors" under a new module - let me know if this should be moved somewhere else! Just browsing around, I couldn't find a good home for it.
  • Created a test for updateAnchor() on class-field-description

@ynotdraw ynotdraw force-pushed the bugfix-properties-link branch from 869c1dc to a9b1391 Compare October 1, 2018 16:57
Copy link
Member

@sivakumar-kailasam sivakumar-kailasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a well rounded PR 🙂 & congrats on your first contribution to this repo 🎉✨✨

@sivakumar-kailasam sivakumar-kailasam merged commit bd08266 into ember-learn:master Oct 2, 2018
Gaurav0 pushed a commit to Gaurav0/ember-api-docs that referenced this pull request Sep 16, 2019
…d_yarn/ember-cli-3.8.1

Bump ember-cli from 3.7.1 to 3.8.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants