-
-
Notifications
You must be signed in to change notification settings - Fork 113
Fix multiple problems with uses and extends #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bededba
to
f13584c
Compare
Thanks for looking at this. I think we should rather fix the reference in the original documentation (emberjs source). This is really just adding a workaround to the UI. We can do this by just change |
Ok. So just that we are on the same page. Ember should not be prefixed and Ember-data will have |
@spruce Yeah, with the onset of JS module import, Many of the classes traditionally referenced using the Ember global namespace are now referenced with imports. In these cases the ember namespaces was removed from inline documentation. For things like ArrayProxy, you can just refer to |
Closing in favor of fixing references in the source documentation |
…ates [OCTANE][FEAT] Templates
As described in the Issue #532 the links created for the Class
DS.RecordArray
are wrong.Instead linking to
/api/ember/3.5/classes/Ember.ArrayProxy and /api/ember-data/3.5/classes/Ember.Evented
when they should link to
/api/ember/3.5/classes/ArrayProxy and /api/ember/3.5/classes/Evented
This is achieved by creating a new helper that removes the
Ember.
prefix and an update to theprojectNameFromClassName()
function.Remaining problems (not caused by this PR):
usedClassProjectName
where the basis for the creation of that prop is a array with possibly multiple entriesDS.Adapter
uses Ember.Object where it should be EmberObject. I will try and find many errors like this in another PR in ember-data source.