Skip to content

Removing Scroll Parent Initializer #598 #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

rahulguptaio
Copy link
Contributor

  1. Removing the 'scroll parent' initializer and test files to reduce Jquery usage in app.
    Remove potentially unused scroll setup #598

Steps to verify if the function is required -

  1. Added a debugger to the scrollParent function in the initializer.
  2. Ran the entire test suite to check if the breakpoint is hit.
  3. No breakpoint is hit, and no test failures either.

1. Removing the 'scroll parent' initializer and test files to reduce Jqeury usage in app
@toddjordan
Copy link
Contributor

LGTM, thank you!

@toddjordan toddjordan merged commit ce80899 into ember-learn:master Mar 29, 2019
Gaurav0 pushed a commit to Gaurav0/ember-api-docs that referenced this pull request Sep 16, 2019
* adding info-banner

* fixing broken pages.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants