Upgrade ember 2.18->3.4 #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started with an LTS jump 2.18->3.4 . I'll do the next jump 3.4->3.8 |
|
Created a heroku review app if you want to check it out 👇 |
MODULE_REPORT.md
Outdated
| @@ -0,0 +1,14 @@ | |||
| ## Module Report | |||
There was a problem hiding this comment.
please remove this file
sivakumar-kailasam
previously requested changes
Apr 3, 2019
acorncom
approved these changes
Apr 4, 2019
fixing up tests
toddjordan
force-pushed
the
upgrade-to-3-4-lts
branch
from
87a5186 to
b158e81
Compare
toddjordan
dismissed
sivakumar-kailasam’s stale review
Removed the generated file. need to leave browserify until ember-algolia is fixed.
Gaurav0
pushed a commit
to Gaurav0/ember-api-docs
that referenced
this pull request
Sep 16, 2019
* Refactor MU filenames * add dots for easier reading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize there was a branch for upgrading already, and I started there, but I quickly got lost in the amount of merge conflicts, as its diverged from master over time. So I started clean and ran ember-cli-update + codemods, and patched up a few broken things in the aftermath and we are here.
I appreciate the work that was already done as it made this effort much easier to be able to look and see what was done.