Remove unmaintained ember-algolia and ember-browserify #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acorncom
approved these changes
Apr 25, 2019
There was a problem hiding this comment.
The original goal with the ember-algolia addon had been to have something that we could share between various Ember sites over time. With ember-auto-import being a thing and most of the work being shared in guidemaker (https://github.com/ember-learn/guidemaker-ember-template/blob/master/addon/services/search.js), I'm 👍 on merging this.
@toddjordan / @mansona any thoughts here?
|
Tested this on my local and it LGTM. So merging it. |
Gaurav0
pushed a commit
to Gaurav0/ember-api-docs
that referenced
this pull request
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.