Removing jQuery usage from app #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbendaou
changed the title
|
Just need to quick refact the |
dbendaou
changed the title
Turbo87
reviewed
May 3, 2019
dbendaou
force-pushed
the
removing_jquery_usage_from_app
branch
from
826d2ea to
3ea27f4
Compare
dbendaou
force-pushed
the
removing_jquery_usage_from_app
branch
from
3ea27f4 to
f896446
Compare
|
Could anyone review this ? 😅 |
|
Sorry about that @dbendaou. I've deployed a preview app to test these changes. |
sivakumar-kailasam
requested changes
Jun 4, 2019
Gaurav0
pushed a commit
to Gaurav0/ember-api-docs
that referenced
this pull request
Sep 16, 2019
…s-and-events ember-learn#588 components/actions-and-events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing jquery usage from test, this PR aims to remove jquery usage in the app.
TODO :
app/components/ember-anchor.js
app/services/scroll-position-reset.js
app/mixins/scroll-tracker.js
Related issue #441