fix async request leaks in fastboot #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@Gaurav0 good work mate. This should also make the site faster too. We should not be downloading every ember version to display the dropdown of ember versions. |
Gaurav0
force-pushed
the
fix_fastboot_leaks
branch
from
d16049c to
aa856ef
Compare
sivakumar-kailasam
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting version ids should not require fetching all versions asynchronously. This prevents that and incidentally prevents async request leaks in fastboot, which I was originally trying to fix.
Thanks to @kiwiupover for all the help today!