Skip to content

Run codemods #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/adapters/application.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import JSONAPIAdapter from '@ember-data/adapter/json-api';
import { inject as service } from '@ember/service';
import DS from 'ember-data';
import fetch from 'fetch';
import ENV from 'ember-api-docs/config/environment';
import { pluralize } from 'ember-inflector';
import { isBlank } from '@ember/utils';

const { JSONAPIAdapter } = DS;

export default JSONAPIAdapter.extend({

host: ENV.API_HOST,
Expand Down
9 changes: 4 additions & 5 deletions app/models/class.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import Model, { belongsTo, attr } from '@ember-data/model';
import { computed } from '@ember/object';
import DS from 'ember-data';
const {attr, belongsTo} = DS;

const projectNameFromClassName = key => {
return computed(key, function() {
Expand Down Expand Up @@ -30,7 +29,7 @@ const guessVersionFor = key => {
});
};

export default DS.Model.extend({
export default Model.extend({
name: attr(),
methods: attr(),
properties: attr(),
Expand All @@ -56,15 +55,15 @@ export default DS.Model.extend({
usedClassVersion: guessVersionFor('uses'),

extendedClassShortName: computed('extends', function() {
let extendedClassName = this.get('extends');
let extendedClassName = this['extends'];
if (extendedClassName.substr(0, 6) === 'Ember.') {
return extendedClassName.substr(6);
}
return extendedClassName;
}),

usesObjects: computed('uses', function() {
return this.get('uses').map(className => ({
return this.uses.map(className => ({
name: className,
shortName: className.substr(0, 6) === 'Ember.' ? className.substr(6) : className,
projectId: className.substr(0, 6) === 'Ember.' ? 'ember' :
Expand Down
5 changes: 1 addition & 4 deletions app/models/missing.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import Model from 'ember-data/model';
import DS from 'ember-data';

const { attr } = DS;
import Model, { attr } from '@ember-data/model';

export default Model.extend({
name: attr()
Expand Down
4 changes: 1 addition & 3 deletions app/models/module.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { belongsTo, attr } from '@ember-data/model';
import ClassModel from './class';
import DS from 'ember-data';

const { attr, belongsTo } = DS;

export default ClassModel.extend({
submodules: attr(),
Expand Down
4 changes: 1 addition & 3 deletions app/models/namespace.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { belongsTo } from '@ember-data/model';
import ClassModel from './class';
import DS from 'ember-data';

const { belongsTo } = DS;

export default ClassModel.extend({
projectVersion: belongsTo('project-version', {inverse: 'namespaces'})
Expand Down
26 changes: 13 additions & 13 deletions app/models/project-version.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import Model, { attr, hasMany, belongsTo } from '@ember-data/model';
import { computed } from '@ember/object';
import DS from 'ember-data';
import getCompactVersion from '../utils/get-compact-version';

export default DS.Model.extend({
version: DS.attr(),
classes: DS.hasMany('class', {async: true}),
modules: DS.hasMany('module', {async: true}),
namespaces: DS.hasMany('namespace', {async: true}),
'public-classes': DS.hasMany('class', {async: true}),
'private-classes': DS.hasMany('class', {async: true}),
'public-modules': DS.hasMany('module', {async: true}),
'private-modules': DS.hasMany('module', {async: true}),
'public-namespaces': DS.hasMany('namespace', {async: true}),
'private-namespaces': DS.hasMany('namespace', {async: true}),
project: DS.belongsTo('project'),
export default Model.extend({
version: attr(),
classes: hasMany('class', {async: true}),
modules: hasMany('module', {async: true}),
namespaces: hasMany('namespace', {async: true}),
'public-classes': hasMany('class', {async: true}),
'private-classes': hasMany('class', {async: true}),
'public-modules': hasMany('module', {async: true}),
'private-modules': hasMany('module', {async: true}),
'public-namespaces': hasMany('namespace', {async: true}),
'private-namespaces': hasMany('namespace', {async: true}),
project: belongsTo('project'),
compactVersion: computed('version', function() {
return getCompactVersion(this.version);
})
Expand Down
4 changes: 1 addition & 3 deletions app/models/project.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import DS from 'ember-data';

const {Model, attr, hasMany} = DS;
import Model, { hasMany, attr } from '@ember-data/model';

export default Model.extend({
name: attr(),
Expand Down
4 changes: 2 additions & 2 deletions app/serializers/application.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import JSONAPISerializer from '@ember-data/serializer/json-api';
import { inject as service } from '@ember/service';
import DS from 'ember-data';

export default DS.JSONAPISerializer.extend({
export default JSONAPISerializer.extend({

metaStore: service(),

Expand Down
3 changes: 1 addition & 2 deletions app/services/search.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import Service from '@ember/service';
import Service, { inject as service } from '@ember/service';
import { task } from 'ember-concurrency';
import { get, set } from '@ember/object';
import { A as emberArray } from '@ember/array';
import { alias } from '@ember/object/computed';
import { inject as service } from '@ember/service';

export default Service.extend({
_algoliaService: service('algolia'),
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/module-test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { module, test } from 'qunit';
import { setupApplicationTest } from 'ember-qunit';
import { visit, click, find, findAll } from '@ember/test-helpers';
import { visit, click, findAll } from '@ember/test-helpers';

module('Acceptance | Module', function(hooks) {
setupApplicationTest(hooks);
Expand Down Expand Up @@ -37,6 +37,6 @@ module('Acceptance | Module', function(hooks) {

const store = this.owner.lookup('service:store');
const container = store.peekRecord('module', 'ember-1.0.0-ember-application');
assert.equal(find(`.attribute-value`).textContent, container.get('parent'));
assert.dom(`.attribute-value`).hasText(container.get('parent'));
});
});
8 changes: 7 additions & 1 deletion tests/acceptance/sidebar-nav-test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import { module, test } from 'qunit';
import { setupApplicationTest } from 'ember-qunit';
import { visit, click, currentURL, find, settled } from '@ember/test-helpers';
import {
visit,
click,
currentURL,
find,
settled
} from '@ember/test-helpers';
import { timeout } from 'ember-concurrency';

module('Acceptance | sidebar navigation', function(hooks) {
Expand Down
7 changes: 6 additions & 1 deletion tests/integration/components/class-field-description-test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import EmberObject from '@ember/object';
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { render, click, findAll, triggerEvent } from '@ember/test-helpers';
import {
render,
click,
findAll,
triggerEvent
} from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile';

module('Integration | Component | class field description', function(hooks) {
Expand Down