Skip to content

Create Ember Data landing page (#638) #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

DanaKirsh
Copy link
Contributor

Closes #638

Create a draft ember data landing page that has a list of commonly-searched-for documentation for Ember Data (models, store, adapters and serializers).

`/ember-data/release`,
'routes to the landing page'
);
assert.dom('h1').hasText('Ember API Documentation');
Copy link
Contributor

@jenweber jenweber Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this test is changed to say "Ember Data API Documentation" for the h1 assertion, would that work?

This test exists to make sure some redirects work from legacy urls, so it's good to keep if we can.

</h2>
<ul class="spec-method-list">
<li>
{{#link-to "project-version.classes.class" "Model"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to break this out to links to the overviews to the respective packages vs to specific classes, with a short explainer that ember-data is a package that assembles these other packages, most of which are not required.

@jenweber
Copy link
Contributor

I definitely want to still get this in. It will be super useful! The blocker is that it's not rendering on the Ember Data page. I tried to get it working in my own branch and had some issues. If anyone wants to give it a try, go for it. I am very rusty on both Ember Data and fastboot.

@runspired
Copy link
Contributor

@jenweber happy to pair, I've gotten the docs running locally recently

@runspired
Copy link
Contributor

@jenweber and I have expanded upon this PR in #761

@jenweber
Copy link
Contributor

The commits for this PR will be included in #761

@jenweber
Copy link
Contributor

Ok, this is merged as part of #761 ! I am waiting on deploying until GitHub clears up their pipeline issues: https://www.githubstatus.com/ so it's not live yet, but will be soon.

Thanks again @DanaKirsh for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Ember Data landing page
3 participants