Update this app to latest Ember and Ember Data #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenweber
changed the title
Has an app runtime error The app builds and renders Need to fix linting issues next Run yarn lint:fix Fix linting and some test failures update README remove page title update README Update ember percy Co-authored-by: Chris Thoburn <[email protected]>
|
@runspired and I click tested this and went through each upgrade step. Everything seems to check out, so I'm going to go ahead and merge. If any problems pop up after deployment, follow the instructions in https://github.com/ember-learn/ember-api-docs/blob/master/DEPLOYING.md to deploy a previous commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.