Skip to content

Get Octanify and codemodded app running with tests passing #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 1, 2021

Conversation

jenweber
Copy link
Contributor

We used lint-to-the-future to ignore linting warnings/errors. This allows us to address them one at a time in future PRs.

jenweber and others added 14 commits August 12, 2021 08:57
Co-authored-by: Chris Manson <[email protected]>
We are working our way through linting warnings
after starting an Octane upgrade.
Co-authored-by: Chris Manson <[email protected]>
Co-authored-by: Chris Manson <[email protected]>
Co-authored-by: Chris Manson <[email protected]>

By ignoring all linting warnings, we can
merge the work so far and get
help resolving the linting errors
one by one.

To recreate this commit:
Run `npx lint-to-the-future ignore`
This enables us to use GitHub pages to
display progress towards removing linting
warnings/errors.
@locks locks temporarily deployed to ember-api-do-jw-cm-octa-s6bedm September 23, 2021 20:14 Inactive
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tried to review commit by commit but it's kinda hard to keep track with the size of the PR 🙈 I think we're good if tests are passing though 👍

@jenweber
Copy link
Contributor Author

jenweber commented Oct 1, 2021

This work was also click tested by rajakvk and no bugs were found! I'm going to go ahead and merge so we can unblock some Hacktoberfest opportunities.

@jenweber jenweber merged commit 4006bdd into master Oct 1, 2021
@jenweber jenweber deleted the jw-cm-octane-rest-stop branch October 1, 2021 18:26
@rajakvk rajakvk mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants