-
-
Notifications
You must be signed in to change notification settings - Fork 113
Get Octanify and codemodded app running with tests passing #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Chris Manson <[email protected]>
We are working our way through linting warnings after starting an Octane upgrade.
Co-authored-by: Chris Manson <[email protected]>
Co-authored-by: Chris Manson <[email protected]>
Co-authored-by: Chris Manson <[email protected]> By ignoring all linting warnings, we can merge the work so far and get help resolving the linting errors one by one. To recreate this commit: Run `npx lint-to-the-future ignore`
This enables us to use GitHub pages to display progress towards removing linting warnings/errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I tried to review commit by commit but it's kinda hard to keep track with the size of the PR 🙈 I think we're good if tests are passing though 👍
This work was also click tested by rajakvk and no bugs were found! I'm going to go ahead and merge so we can unblock some Hacktoberfest opportunities. |
We used lint-to-the-future to ignore linting warnings/errors. This allows us to address them one at a time in future PRs.