Skip to content

Fix linting error (#775) #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

rajakvk
Copy link
Contributor

@rajakvk rajakvk commented Oct 18, 2021

Closes #775

Item number 4 (app/components/class-field-description.js)

@jenweber
Copy link
Contributor

Let's see if this works:

/* ember/classic-decorator-no-classic-methods */
import { inject as service } from '@ember/service';
import Component from '@ember/component';

export default class ClassFieldDescription extends Component {
  @service
  legacyModuleMappings;

  get hasImportExample() {
    return this.legacyModuleMappings.hasFunctionMapping(
      this.args.field.name,
      this.args.field.class
    );
  }

  /**
   * Callback for updating the anchor with the field name that was clicked by a user.
   *
   * @method updateAnchor
   * @method fieldName String The name representing the field that was clicked.
   */
  updateAnchor() {}
}

@rajakvk
Copy link
Contributor Author

rajakvk commented Oct 22, 2021

Removed @Tracked as suggested by the team. @jenweber

Comment on lines 10 to 11
this.args.field.name,
this.args.field.class
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will not work since it's an @ember/component. Try:

Suggested change
this.args.field.name,
this.args.field.class
this.field.name,
this.field.class

Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change which I believe will fix the tests.

@rajakvk rajakvk force-pushed the rk-775-fix-linting-error-3 branch from d0373fc to 418cb64 Compare November 5, 2021 06:22
@locks locks force-pushed the rk-775-fix-linting-error-3 branch from 418cb64 to f1cb13d Compare November 8, 2021 16:28
@locks locks merged commit 8149f2a into ember-learn:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix eslint issues
3 participants