Fix linting error (#775) #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
locks
requested changes
Oct 28, 2021
app/components/ember-anchor.js
Outdated
| @@ -8,7 +6,7 @@ export default class EmberAnchor extends AnchorComponent { | |||
| // This overrides Ember Anchor to support scrolling within a fixed position element | |||
| _scrollToElemPosition() { | |||
| let qp = this.anchorQueryParam; | |||
| let qpVal = this.get(get(this, 'attrs.a') ? 'a' : `controller.${qp}`); | |||
| let qpVal = this[this['attrs.a'] ? 'a' : `controller.${qp}`]; | |||
There was a problem hiding this comment.
I believe what the original code was doing is this:
Suggested change
| let qpVal = this[this['attrs.a'] ? 'a' : `controller.${qp}`]; | |
| let qpVal = this.a ?? this.controller[qp]; |
this['attrs.a'] is actually subtly wrong because it will try to retrieve the property named attrs.a.
Ember's get doesn't allow properties with periods, because it retrieves nested properties.
So, this.get('attrs.a') translated to this.attrs.a and this['attrs.a'] translates to this['attrs.a'].
Or, represented as objects:
{
attrs: { a: "" }
}
{
"attrs.a": {}
}
rajakvk
force-pushed
the
rk-775-fix-linting-error-4
branch
from
d0ef851 to
9a7b385
Compare
locks
force-pushed
the
rk-775-fix-linting-error-4
branch
2 times, most recently
from
50be96e to
265a2e8
Compare
locks
force-pushed
the
rk-775-fix-linting-error-4
branch
from
265a2e8 to
a2a8cae
Compare
locks
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #775 Item 5
File: app/components/ember-anchor.js