Skip to content

Fix search #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Fix search #791

merged 2 commits into from
Jan 24, 2022

Conversation

mansona
Copy link
Member

@mansona mansona commented Jan 22, 2022

Fixes #788

The issue was introduced automatically by a codemod in d25f6b2 and unfortunately it looks like some of the other {{link-to}} modded code in that same commit has the same problem 🙈

We should probably go through each one and make sure it works or at least is covered by a test and verify that it's broken

Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct but I'm not sure what's going on in Percy. Thank you for figuring this out!

@locks locks temporarily deployed to ember-api-do-fix-search-0fbnjl January 22, 2022 22:59 Inactive
@mansona
Copy link
Member Author

mansona commented Jan 22, 2022

@MelSumner the issue with Percy is that we haven't merged anything since 4.0 and the version in the left hand side is out of date, and there seems to have been a class removed in 4.0 "Checkbox" 🤷 so all of the ToC have moved up one

@locks locks merged commit 2fca6bf into master Jan 24, 2022
@locks locks deleted the fix-search branch January 24, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Algolia search is broken
3 participants