Follow-up items from updating table of contents component to glimmer #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's avoid using the `action` helper and instead prefer to use the `on` and `fn` helpers together. These new helpers have more clearly delineated responsibilities, which should make the operations a little bit easier to understand.
Let's avoid using the `Input` component, as this provides a two-way binding on the @checked argument. Let's use the regular `input` tag here with an `onchange` helper to handle the toggling event.
chriskrycho
approved these changes
Nov 19, 2022
Comment on lines
+125
to
+128
| @action | ||
| togglePrivateClasses() { | ||
| set(this, 'showPrivateClasses', !this.showPrivateClasses); | ||
| } |
There was a problem hiding this comment.
Let's also follow up on this and get rid of the CP macro in favor of actually using tracked state on the service. I know that the service and the way these CPs work are a bit janky today, but I did a spike where I just swapped it all out for a simple set of tracked properties and not trying to do those janky things in the CPs and it actually “just worked” (though we should of course verify that).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's follow-up on the suggested tweaks to the table-of-contents component from: #809 by:
actionhelperInputcomponent which provides a 2-way binding on the@checkedarg