Skip to content

Switch away from deprecated Route.transitionTo #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Conversation

chriskrycho
Copy link
Contributor

This sets us up nicely for Ember v4, where this isn't present. It also removes an unused mixin!

@chriskrycho chriskrycho mentioned this pull request Nov 19, 2022
@chriskrycho
Copy link
Contributor Author

Odd, unclear why tests are failing. I will poke at this at some point Soon™; if someone else beats me to it, help welcome!

@geneukum
Copy link
Contributor

TIL - per the RouterService docs:

Calling transitionTo from the Router service will cause default query parameter values to be included in the URL. This behavior is different from calling transitionTo on a route or transitionToRoute on a controller.

Adding this extra ?show=inherited query string to the expected URL seemed to get all of those tests passing again.

@chriskrycho
Copy link
Contributor Author

Ah, yep, that would do it! Thank you!

@chriskrycho chriskrycho merged commit cdf1fa2 into master Nov 20, 2022
@chriskrycho chriskrycho deleted the transitionTo branch November 20, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants