Skip to content

Set Node to v14 #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Set Node to v14 #843

merged 1 commit into from
Dec 2, 2022

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Dec 2, 2022

To accommodate libsass, and make this deployable to Heroku, we need to stay at v14 of node.

We can upgrade the node version once we update ember-styleguide.

This reinstates the work in #834 which had a regression in #835

To accommodate libsass, and make this deployable to Heroku, we need to stay at v14 of node.

We can upgrade the node version once we update ember-styleguide.
@jenweber jenweber requested a review from mansona December 2, 2022 13:29
@jenweber jenweber temporarily deployed to ember-api-docs-staging December 2, 2022 13:53 Inactive
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 but also 😭

@jenweber jenweber merged commit 97249c5 into master Dec 2, 2022
@jenweber jenweber deleted the jw-node-version branch December 2, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants