Skip to content

Bugfix for Ember Data landing page #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Jan 27, 2023

Older versions of Ember Data were unreachable if they did not have an "overview" module.

Reproduction:

  • visit api.emberjs.com
  • select a version older than 4.6 from the dropdown
  • get a 404

This is not the nicest way to fix this, but I think it works.

Older versions of Ember Data were
unreachable if they did not have an "overview" module.
@jenweber jenweber force-pushed the jw-fix-ember-data-landing-page branch from 6737de3 to bc3657e Compare January 27, 2023 13:17
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@jenweber jenweber merged commit 9991c56 into master Jan 27, 2023
@jenweber jenweber deleted the jw-fix-ember-data-landing-page branch January 27, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants