Merge pull request #327 from ember-learn/add-aria-label-nav

mansona · web-flow · commit 516fc9407db1 · 2020-06-04T12:37:01.000+01:00
Add an aria-label to the primary nav element
diff --git a/addon/templates/components/es-header.hbs b/addon/templates/components/es-header.hbs
@@ -3,7 +3,7 @@
   role="banner"
   ...attributes
 >
-  <nav class="es-navbar {{if this.expanded "navbar-expanded"}}">
+  <nav class="es-navbar {{if this.expanded "navbar-expanded"}}" aria-label="Primary site navigation">
     <a class="navbar-brand-wrapper" href={{this.navHome}}>
       <img
         class="navbar-brand"

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`role="banner"`
`4`	`4`	`...attributes`
`5`	`5`	`>`
`6`		`- <nav class="es-navbar {{if this.expanded "navbar-expanded"}}">`
	`6`	`+ <nav class="es-navbar {{if this.expanded "navbar-expanded"}}" aria-label="Primary site navigation">`
`7`	`7`	`<a class="navbar-brand-wrapper" href={{this.navHome}}>`
`8`	`8`	`<img`
`9`	`9`	`class="navbar-brand"`