Skip to content

Add an aria-label to the primary nav element #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2020
Merged

Add an aria-label to the primary nav element #327

merged 1 commit into from
Jun 4, 2020

Conversation

nickschot
Copy link
Contributor

@nickschot nickschot requested review from mansona and MelSumner June 4, 2020 10:12
mansona
mansona approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@mansona mansona merged commit 516fc94 into master Jun 4, 2020
@mansona mansona deleted the add-aria-label-nav branch June 4, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

@MelSumner MelSumner Awaiting requested review from MelSumner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickschot @mansona