Merge pull request #125 from esbanarango/esbanarango/123-es-footer-to-angle-bracket-component

[#123] / Convert es-footer to be an angle bracket component

Author: amyrlam

addon/templates/components/es-footer.hbs

@@ -13,7 +13,7 @@
 
       {{!--
         Pass footer properties to support
-        {{es-footer tagline="My custom tagline" contributorLinks=myLinks}}
+        <EsFooter @tagline="My custom tagline" @contributorLinks={{myLinks}}/>
       --}}
       {{es-footer/es-info infoLinks=infoLinks}}
       {{es-footer/es-statement tagline=tagline socialLinks=socialLinks}}

package.json

@@ -56,7 +56,7 @@
     "ember-cli-deploy-git": "^1.3.3",
     "ember-cli-deploy-git-ci": "^1.0.1",
     "ember-cli-eslint": "^4.2.3",
-    "ember-cli-htmlbars-inline-precompile": "^1.0.3",
+    "ember-cli-htmlbars-inline-precompile": "^1.0.5",
     "ember-cli-inject-live-reload": "^2.0.1",
     "ember-cli-mirage": "^0.4.9",
     "ember-cli-moment-shim": "^3.5.0",

tests/dummy/app/templates/docs/components/es-footer.md

@@ -2,14 +2,14 @@
 
 {{#docs-demo as |demo|}}
   {{#demo.example name='demo1'}}
-    {{es-footer }}
+    <EsFooter/>
   {{/demo.example}}
   {{demo.snippet 'demo1'}}
 {{/docs-demo}}
 
 {{#docs-demo as |demo|}}
   {{#demo.example name='demo2'}}
-    {{es-footer tagline="A framework for ambitious web developers"}}
+    <EsFooter @tagline="A framework for ambitious web developers"/>
   {{/demo.example}}
   {{demo.snippet 'demo2'}}
 {{/docs-demo}}
@@ -18,37 +18,37 @@
   {{#demo.example name='demo3'}}
     {{!-- Check out the component blocks and their respective
     configuration --}}
-    {{#es-footer as |f|}}
-      {{f.info infoLinks=infoLinks}}
-      {{f.statement socialLinks=socialLinks}}
-      {{f.contributions contributorLinks=contributorLinks}}
-    {{/es-footer}}
+    <EsFooter as |f|>
+      <f.info @infoLinks={{infoLinks}} />
+      <f.statement @socialLinks={{socialLinks}} />
+      <f.contributions @contributorLinks={{contributorLinks}} />
+    </EsFooter>
   {{/demo.example}}
   {{demo.snippet 'demo3'}}
 {{/docs-demo}}
 
 {{#docs-demo as |demo|}}
   {{#demo.example name='demo4'}}
     {{!-- You can also add your own content on each component block --}}
-    {{#es-footer as |f|}}
-      {{#f.info}}
+    <EsFooter as |f|>
+      <f.info>
         <br/>
         <a>Team</a>
         <br/>
         <a>Contact</a>
-      {{/f.info}}
-      {{#f.statement}}
+      </f.info>
+      <f.statement>
         Highly Productive Out of the Box
-      {{/f.statement}}
-      {{#f.contributions}}
+      </f.statement>
+      <f.contributions>
         <div class="contributor">
           <p>Hosted by:</p>
           <a href="https://www.heroku.com/emberjs">
             {{svg-jar "heroku-logo" class="contributor-logo"}}
           </a>
         </div>
-      {{/f.contributions}}
-    {{/es-footer}}
+      </f.contributions>
+    </EsFooter>
   {{/demo.example}}
   {{demo.snippet 'demo4'}}
 {{/docs-demo}}

tests/integration/components/es-footer-test.js

@@ -7,7 +7,7 @@ module('Integration | Component | es footer', function(hooks) {
   setupRenderingTest(hooks);
 
   test('it renders', async function(assert) {
-    await render(hbs`{{es-footer}}`);
+    await render(hbs`<EsFooter/>`);
 
     const footerSocialLinks = document.querySelectorAll('.footer-social a');
     const footerContribtuionsLinks = document.querySelectorAll('.footer-contributions .contributor');

yarn.lock

@@ -4778,7 +4778,7 @@ ember-cli-htmlbars-inline-precompile@^1.0.0:
     heimdalljs-logger "^0.1.9"
     silent-error "^1.1.0"
 
-ember-cli-htmlbars-inline-precompile@^1.0.3:
+ember-cli-htmlbars-inline-precompile@^1.0.3, ember-cli-htmlbars-inline-precompile@^1.0.5:
   version "1.0.5"
   resolved "https://registry.yarnpkg.com/ember-cli-htmlbars-inline-precompile/-/ember-cli-htmlbars-inline-precompile-1.0.5.tgz#312e050c9e3dd301c55fb399fd706296cd0b1d6a"
   integrity sha512-/CNEqPxroIcbY6qejrt704ZaghHLCntZKYLizFfJ2esirXoJx6fuYKBY1YyJ8GOgjfbHHKjBZuK4vFFJpkGqkQ==