[#123] / Convert es-footer to be an angle bracket component #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2018
dbollinger
reviewed
Mar 18, 2019
|
@MelSumner Let me know if there's something missing here. Happy to work on any missing part. |
esbanarango
changed the base branch from
master
to
feature/angle-bracket-components
esbanarango
changed the base branch from
feature/angle-bracket-components
to
master
|
@amyrlam No worries! Thank YOU for taking the time to review it. |
|
@esbanarango cool! I was trying to make this change on your branch, I don't think I can push to your fork, but I may be doing something wrong(?): 25fb97b Let me know, also I'm @ amyrlam on Ember Discord if easier to sync there. |
amyrlam
added a commit
that referenced
this pull request
Apr 26, 2019
Fix from out-of-date branch #125 Co-authored-by: Esteban Arango Medina <[email protected]>
amyrlam
added a commit
that referenced
this pull request
Apr 26, 2019
Fix from out-of-date branch #125 Co-authored-by: Esteban Arango Medina <[email protected]>
amyrlam
reviewed
Apr 26, 2019
.travis.yml
Outdated
| @@ -37,8 +37,6 @@ jobs: | |||
| # we recommend new addons test the current and previous LTS | |||
| # as well as latest stable release (bonus points to beta/canary) | |||
| - stage: "Additional Tests" | |||
| env: EMBER_TRY_SCENARIO=ember-lts-2.16 | |||
There was a problem hiding this comment.
Sorry for the confusion on my end. I meant to keep the .travis.yml the same as what's on master. Unfortunately I can't push to this branch of your fork. I believe when you add these 2 lines back, there will still be some test failures.
I'm not sure about @tagline="My custom tagline" maybe it needs to be in curlies also.
hakilebara
force-pushed
the
esbanarango/123-es-footer-to-angle-bracket-component
branch
from
fbbd018 to
ba68377
Compare
amyrlam
approved these changes
Apr 26, 2019
esbanarango
deleted the
esbanarango/123-es-footer-to-angle-bracket-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts
{{es-footer}}component to<EsFooter/>. #123Note: This PR also adds ember-angle-bracket-invocation-polyfill, so we can continue supporting
2.16and2.18versions.