Skip to content

use angle-bracket syntax for es-note component #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2019

Conversation

jbailey4
Copy link
Contributor

@jbailey4 jbailey4 commented Dec 3, 2018

Closes #124

@jbailey4 jbailey4 force-pushed the es-note-angle-bracket branch from dd860b8 to 9406071 Compare December 3, 2018 02:14
@jbailey4 jbailey4 force-pushed the es-note-angle-bracket branch from 9406071 to 9c61054 Compare December 3, 2018 02:15
@jbailey4
Copy link
Contributor Author

jbailey4 commented Dec 3, 2018

Once #125 is merged, I can rebase and tests should pass since angle-bracket support was backfilled for ember versions 2.16 and 2.18 and those versions would be marked as allowed failures.

Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbailey4 sorry this was open for so long, looks good, thanks for the contribution! 🎉

@amyrlam amyrlam merged commit 69009fb into ember-learn:master Apr 25, 2019
@jbailey4 jbailey4 deleted the es-note-angle-bracket branch May 10, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert es-note to angle bracket component
4 participants