Skip to content

convert es-ulist to Angle Bracket #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

convert es-ulist to Angle Bracket #130

wants to merge 3 commits into from

Conversation

hakubo
Copy link

@hakubo hakubo commented Dec 6, 2018

Aims to close #117

  • it could be simplified even further if components were in app folder instead of in addon
    • if that was true es-ulist-elements could be a true template only component
  • this PR also add support for 'ol' lists and ads some tests for es-ulist component

@mansona mansona mentioned this pull request Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amyrlam amyrlam

@hakilebara hakilebara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert es-ulist to an angle bracket component
4 participants
@hakubo @amyrlam @hakilebara @MelSumner