Skip to content

Remove tabs implementation #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Remove tabs implementation #201

merged 1 commit into from
Aug 15, 2019

Conversation

mansona
Copy link
Member

@mansona mansona commented Aug 15, 2019

As ember-learn/ember-website#365 has gone in a different direction and we don't need a "tabs" component any more we should remove it 👍

Closes #157

@mansona mansona requested a review from a team August 15, 2019 10:49
@balinterdi
Copy link
Contributor

Lgtm, not sure why Netlify checks are failing, though.

@mansona
Copy link
Member Author

mansona commented Aug 15, 2019

@balinterdi the Netlify build fails because they don't use npm ci for installs and you always need to "clear cache and redeploy" when working with this PR to a PR'd branch 😞 I've told them about it and they said it's a "won't fix" from their end

@balinterdi
Copy link
Contributor

I see, strange. I also had the same problem with my chess project, now I know what that is.

Thanks, I'll merge the PR now.

@balinterdi balinterdi merged commit 805971f into website-redesign-rfc Aug 15, 2019
@balinterdi balinterdi deleted the remove-tabs branch August 15, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants