Skip to content

Deprecate es pagewrapper #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,4 @@ For more information on using ember-cli, visit [https://ember-cli.com/](https://
* Each component must have the component name attached to the component as a CSS class.
* It may feel as though there is duplicated code throughout these components; during the WIP process, we are favoring duplication over abstraction.
* Font icons through [ember-fontawesome](https://fontawesome.com/how-to-use/on-the-web/using-with/ember) - it is supported by the font awesome team and they render to SVG.
* The `es-pagewrapper` component has a property to indicate if there will be a sidebar or not. There might be a better way to do this.
* In this addon, the `section` element is used as a container and is intended to span the full width of the viewport.
12 changes: 12 additions & 0 deletions addon/components/es-pagewrapper.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,20 @@
import Component from '@ember/component';
import layout from '../templates/components/es-pagewrapper';

import { deprecate } from '@ember/application/deprecations';

export default Component.extend({
layout,

init() {
this._super(...arguments);

deprecate('es-pagewrapper is deprecated and will be removed in the next version of ember-styleguide. If you think this has been done in error please contact the Learning Team in #dev-ember-learning in the Ember Community Discord.', null, {
id: 'styleguide-es-ulist',
until: '4.0.0'
});
},

classNameBindings: ['hasAside:pagewrapper-aside:pagewrapper'],
hasAside: false,
ariaRole: 'presentation',
Expand Down
2 changes: 2 additions & 0 deletions tests/dummy/app/templates/docs/components/es-pagewrapper.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Page Wrapper

**Note: this component is deprecated and will be removed in the next version of ember-styleguide**

{{#docs-demo as |demo|}}
{{#demo.example name='es-pagewrapper'}}
{{es-pagewrapper}}
Expand Down
2 changes: 2 additions & 0 deletions tests/dummy/app/templates/docs/components/es-ulist.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

The list component is an unstyled, unordered list. A title must be defined, but can be visually hidden.

**Note: this component is deprecated and will be removed in the next version of ember-styleguide**

## Uses

### Unstyled, Unordered List
Expand Down