Skip to content

Set body and text color #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2019
Merged

Set body and text color #213

merged 1 commit into from
Oct 5, 2019

Conversation

ghislaineguerin
Copy link
Member

fixes #208

@ghislaineguerin
Copy link
Member Author

@MelSumner Does this fix the issue. Not sure if we need to use actual HEX colors or is it ok to use the variables here.

MelSumner
MelSumner approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MelSumner MelSumner merged commit 9f8a560 into website-redesign-rfc Oct 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the set-body-text-color branch October 5, 2019 13:08
@mansona
Copy link
Member

mansona commented Oct 7, 2019

@ghislaineguerin just for reference: the postcss build process will automatically include fallback CSS for browsers that don't support variables 👍 you should never have to worry about these things when developing 🎉

@mansona mansona mentioned this pull request Oct 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghislaineguerin @mansona @MelSumner