improve typography and color docs #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelSumner
reviewed
Sep 12, 2019
MelSumner
requested changes
Sep 12, 2019
docs/concepts/colours.md
Outdated
| ### Here we talk about the color scheme | ||
| ### Usage | ||
| #### Legibility | ||
| Website elements like text and icons should meet accesibility standards when used against coloured backgrounds. The following swatches contain a sample of each of the primary palette colours, along with recommendations for its usage and the acceptable contrast guidelines when coupled with text. |
There was a problem hiding this comment.
Please correct spelling for American English (all of the Ember documentation follows this pattern)
docs/concepts/typography.md
Outdated
| Text legibility is primarily affected by color. All text on the website should comply with the Web Content Accessibility Guidelines (WCAG 2.0) Level AA requirements. | ||
|
|
||
|
|
||
| Please refer to the <a href="colours">Colours</a> section for more information on colour contrast and accessibility. |
There was a problem hiding this comment.
Maybe a find and replace for colour -> color.
MelSumner
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR closes #211
It also includes some adjustments to typography proportion and spacing to improve legibility of blocks of text.