Skip to content

Removed alternate text for es-note component, which will show Zoey or Tomster image #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2019
Merged

Removed alternate text for es-note component, which will show Zoey or Tomster image #216

merged 1 commit into from
Oct 2, 2019

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Oct 1, 2019

Now, all images with a presentation role have an empty alt text.
after_changes_2

MelSumner
MelSumner approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for doing this!

@MelSumner MelSumner merged commit f03492c into ember-learn:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijlee2 @MelSumner