Skip to content

Remove Github parenthetical from Help Wanted contributing link #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2020
Merged

Remove Github parenthetical from Help Wanted contributing link #308

merged 2 commits into from
Jun 22, 2020

Conversation

locks
Copy link
Contributor

@locks locks commented Apr 20, 2020

No description provided.

mansona
mansona previously requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you target the website-redesign-rfc branch for this change please? we are likely going to be releasing that this week 👍

@locks locks changed the base branch from master to website-redesign-rfc April 20, 2020 17:17
MelSumner
MelSumner requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should say more than just "Contribute" - "contribute to this page" or "contribute to the ecosystem" or something similar?

@mansona mansona dismissed their stale review April 21, 2020 10:47

Requested changes were made

@mansona
Copy link
Member

mansona commented Apr 21, 2020

It should say more than just "Contribute" - "contribute to this page" or "contribute to the ecosystem" or something similar?

How about "Contribute to Ember" @MelSumner? It needs to be slightly more generic than "Contribute to this page" because it links to the help wanted app 🤔

locks
locks commented Apr 24, 2020
View reviewed changes
MelSumner
MelSumner approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@locks
Copy link
Contributor Author

locks commented May 23, 2020

CI is failing on beta and canary branches with the following message:

        Error: Assertion Failed: Custom modifier managers must define their capabilities using the capabilities() helper function

@mansona mansona changed the base branch from website-redesign-rfc to master June 22, 2020 19:29
@mansona mansona merged commit 8310eb1 into master Jun 22, 2020
@mansona mansona deleted the locks-patch-1 branch June 22, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona left review comments

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@locks @mansona @MelSumner