Skip to content

Simplify EsHeaderComponent implementation. #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Simplify EsHeaderComponent implementation. #319

merged 2 commits into from
Apr 29, 2020

Conversation

alexeykostevich
Copy link

  • Update the component to use Ember Octane API.
  • Remove the code for reseting expanded on CSS breakpoints for
    a more predictable behaviour and prevention of memory leaks.
  • Add navbar-expanded class to simplify styles and reduce coupling
    with HTML structure.
  • Fix accessibility warnings.
  • Add additional tests.

- Update the component to use Ember Octane API.
- Remove the code for reseting `expanded` on CSS breakpoints for
  a more predictable behaviour and prevention of memory leaks.
- Add `navbar-expanded` class to simplify styles and reduce coupling
  with HTML structure.
- Fix accessibility warnings.
- Add additional tests.
@alexeykostevich
Copy link
Author

alexeykostevich commented Apr 29, 2020

Recreate a PR to address the issues with history in #303.

@mansona , please, let me know if anything else is needed.

@mansona
Copy link
Member

mansona commented Apr 29, 2020

@alexeykostevich thanks for updating the PR 👍 it makes it much easier to review now 🎉

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great simplification of a bunch of different parts of the component, just one request about using @tracked because of the current versions that we are trying to support but I don't think it will be super difficult to replace 👍

@mansona mansona merged commit b1fad63 into ember-learn:master Apr 29, 2020
@mansona
Copy link
Member

mansona commented Apr 29, 2020

@alexeykostevich thanks for doing this, and thanks for sticking with it 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants