Skip to content

Avoid modifier manager capabilities deprecation #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2019
Merged

Avoid modifier manager capabilities deprecation #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f7d80d
Add capabilities to modifier managers
wongpeiyi Aug 18, 2019
94fab06
Use @ember/modifier (update ember-modifier-manager-polyfill).
Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions addon/modifiers/did-insert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Ember from 'ember';
import { setModifierManager, capabilities } from '@ember/modifier';

/**
The `{{did-insert}}` element modifier is activated when an element is
Expand Down Expand Up @@ -44,8 +44,10 @@ import Ember from 'ember';
@method did-insert
@public
*/
export default Ember._setModifierManager(
export default setModifierManager(
() => ({
capabilities: capabilities('3.13'),

createModifier() {},

installModifier(_state, element, args) {
Expand Down
6 changes: 4 additions & 2 deletions addon/modifiers/did-update.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Ember from 'ember';
import { setModifierManager, capabilities } from '@ember/modifier';

/**
The `{{did-update}}` element modifier is activated when any of its arguments
Expand Down Expand Up @@ -56,8 +56,10 @@ import Ember from 'ember';
@method did-update
@public
*/
export default Ember._setModifierManager(
export default setModifierManager(
() => ({
capabilities: capabilities('3.13'),

createModifier() {
return { element: null };
},
Expand Down
6 changes: 4 additions & 2 deletions addon/modifiers/will-destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Ember from 'ember';
import { setModifierManager, capabilities } from '@ember/modifier';

/**
The `{{will-destroy}}` element modifier is activated immediately before the element
Expand Down Expand Up @@ -38,8 +38,10 @@ import Ember from 'ember';
@method will-destroy
@public
*/
export default Ember._setModifierManager(
export default setModifierManager(
() => ({
capabilities: capabilities('3.13'),

createModifier() {
return { element: null };
},
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
"test:all": "ember try:each"
},
"dependencies": {
"ember-cli-babel": "^7.1.2",
"ember-modifier-manager-polyfill": "^1.0.1"
"ember-cli-babel": "^7.10.0",
"ember-modifier-manager-polyfill": "^1.1.0"
},
"devDependencies": {
"@ember/optional-features": "^0.7.0",
Expand Down
Loading