Skip to content

feat: enhancements for Helm #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2022
Merged

feat: enhancements for Helm #18

merged 1 commit into from
Jan 9, 2022

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Jan 7, 2022

Hi,

I would like to use this helm chart for deploying our agents but need, due to compliance issues, add some features:

  • reference to PAT in Secret
  • additional Env Variables (eg. for Proxy etc)
  • additiona Volumes (.proxybypass as conifg file) + volume mounts
  • Support for initContainers

Hope you like the features, if something does not your contribution guidlines let me know I will fix id.

I did not increment the Chart Version, as I don't know your process :)

Kind regards.

Signed-off-by: Engin Diri [email protected]

…s, extraVolumes and additionalEnv

Signed-off-by: Engin Diri <[email protected]>
@winromulus
Copy link
Contributor

hi @dirien
Thank you so much for your contribution!
Sorry for the late response, in the middle of moving, and took me a while to get to this

Copy link
Contributor

@winromulus winromulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winromulus winromulus merged commit 70ded6c into emberstack:main Jan 9, 2022
@dirien dirien deleted the helm branch January 9, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants