Fix for flag added to wrong test_embind in #20758 (#20760)

Author: sbc100

test/test_core.py

@@ -7649,9 +7649,6 @@ def test2():
   })
   def test_embind(self, args):
     self.maybe_closure()
-    # This test explicitly creates std::string from unsigned char pointers
-    # which is deprecated in upstream LLVM.
-    self.emcc_args.append('-Wno-deprecated-declarations')
     create_file('test_embind.cpp', r'''
       #include <stdio.h>
       #include <emscripten/val.h>

test/test_other.py

@@ -2923,6 +2923,9 @@ def test_embind_closure_no_dynamic_execution(self):
   })
   def test_embind(self, *extra_args):
     self.emcc_args += [
+      # This test explicitly creates std::string from unsigned char pointers
+      # which is deprecated in upstream LLVM.
+      '-Wno-deprecated-declarations',
       '-lembind',
       '-sRETAIN_COMPILER_SETTINGS',
       '-sEXPORTED_RUNTIME_METHODS=getCompilerSetting',