Skip to content

Commit fceb56a

Browse files
authored
[NFC] [Docs] Some comments in settings.js (#17410)
1 parent 97b7e2e commit fceb56a

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

src/settings.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,10 @@
4949

5050
// Tuning
5151

52-
// Whether we should add runtime assertions, for example to
53-
// check that each allocation to the stack does not
54-
// exceed its size, whether all allocations (stack and static) are
55-
// of positive size, etc., whether we should throw if we encounter a bad __label__, i.e.,
56-
// if code flow runs into a fault
52+
// Whether we should add runtime assertions. This affects both JS and how
53+
// system libraries are built.
5754
// ASSERTIONS == 2 gives even more runtime checks, that may be very slow. That
58-
// includes internal dlmalloc assertions.
55+
// includes internal dlmalloc assertions, for example.
5956
// [link]
6057
var ASSERTIONS = 1;
6158

@@ -1732,6 +1729,7 @@ var AUTO_NATIVE_LIBRARIES = true;
17321729
// are desired to work. Pass -sMIN_FIREFOX_VERSION=majorVersion to drop support
17331730
// for Firefox versions older than < majorVersion.
17341731
// Firefox ESR 60.5 (Firefox 65) was released on 2019-01-29.
1732+
// MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
17351733
// [link]
17361734
var MIN_FIREFOX_VERSION = 65;
17371735

@@ -1742,26 +1740,29 @@ var MIN_FIREFOX_VERSION = 65;
17421740
// NOTE: Emscripten is unable to produce code that would work in iOS 9.3.5 and
17431741
// older, i.e. iPhone 4s, iPad 2, iPad 3, iPad Mini 1, Pod Touch 5 and older,
17441742
// see https://github.com/emscripten-core/emscripten/pull/7191.
1743+
// MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
17451744
// [link]
17461745
var MIN_SAFARI_VERSION = 120000;
17471746

17481747
// Specifies the oldest version of Internet Explorer to target. E.g. pass -s
17491748
// MIN_IE_VERSION = 11 to drop support for IE 10 and older.
17501749
// Internet Explorer is at end of life and does not support WebAssembly.
1751-
// MAX_INT (0x7FFFFFFF) specifies that target is not supported.
1750+
// MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
17521751
// [link]
17531752
var MIN_IE_VERSION = 0x7FFFFFFF;
17541753

17551754
// Specifies the oldest version of Edge (EdgeHTML, the non-Chromium based
17561755
// flavor) to target. E.g. pass -sMIN_EDGE_VERSION=40 to drop support for
17571756
// EdgeHTML 39 and older.
17581757
// Edge 44.17763 was released on November 13, 2018
1758+
// MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
17591759
// [link]
17601760
var MIN_EDGE_VERSION = 44;
17611761

17621762
// Specifies the oldest version of Chrome. E.g. pass -sMIN_CHROME_VERSION=58 to
17631763
// drop support for Chrome 57 and older.
17641764
// Chrome 75.0.3770 was released on 2019-06-04
1765+
// MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
17651766
// [link]
17661767
var MIN_CHROME_VERSION = 75;
17671768

0 commit comments

Comments
 (0)