[NFC] Some comments in settings.js #17410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Jul 11, 2022
| // [link] | ||
| var MIN_EDGE_VERSION = 44; | ||
|
|
||
| // Specifies the oldest version of Chrome. E.g. pass -sMIN_CHROME_VERSION=58 to | ||
| // drop support for Chrome 57 and older. | ||
| // Chrome 75.0.3770 was released on 2019-06-04 | ||
| // MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported. |
There was a problem hiding this comment.
Does -1 really work? If so maybe just stick to that and drop the 0x7FFFFFFF magic?
There was a problem hiding this comment.
Yes, it does work. We have code to convert them in emcc.py.
I agree it makes sense to simplify this, and -1 is probably better. I can look into that as a followup.
There was a problem hiding this comment.
Or I guess this is so small I could wait and do it here.
There was a problem hiding this comment.
Oh, reading the emcc.py code, it is necessary to use 0x7fffffff, as it's a large positive number, which the code depends on. So we just have some parsing support for -1 that we turn it into 0x7fffffff, but use the latter internally. Not sure that makes sense to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.