Handle rejection of promise when binary download fails #12407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a pull request! If this is your first PR, make sure to add yourself to AUTHORS. |
stephanreiter
changed the title
…verter asynchronously Fixes #12395
kripken
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Thanks!
This will handle the rejection, making it not fail the whole application, but I think that's indeed what we want here. If we somehow fail, wasmOffsetConverter will be null, and if it's used later we'll see an error, plus it's logged. The other case in the other PR, of handling rejections for the main download, is trickier...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids an unhandled promise rejection error.
Fixes #12395