Fix asan.test_fs_trackingdelegate by fixing open() call #15021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDLlo
pushed a commit
to CDLlo/emscripten
that referenced
this pull request
Oct 4, 2021
…ore#15021) It turns out that when O_CREAT is given to open(), one must also provide the flags with which to create the file. Not providing that varargs param is apparently undefined behavior, and the musl open() method will end up reading a vararg that does not exist, which leads to a null deref.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that when
O_CREATis given toopen(), one mustalso provide the flags with which to create the file. Not providing
that varargs param is apparently undefined behavior, and the
musl
open()method will end up reading a vararg that does notexist, which leads to a null deref.