Simplify + optimize lengthBytesUTF8. Don't fully decode surrogates #17413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Jul 15, 2022
sbc100
reviewed
Jul 15, 2022
sbc100
reviewed
Jul 15, 2022
sbc100
approved these changes
Jul 15, 2022
|
For some reason circleci doesn't seem to be running on this PR... you are not supposed to need to circleci account to run these but we have has issues in the past where it appeared to help. Would you mind trying to log in to circleci? |
auto-merge was automatically disabled
July 15, 2022 17:59
Head branch was pushed to by a user without write access
|
Looks like all tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lengthBytesUTF8can be simplified and don't fully decode code point to low & high surrogates for UTF8 length calculation.