Skip to content

Only call git on a git repository #18441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

MarcusCalhoun-Lopez
Copy link
Contributor

No description provided.

@sbc100
Copy link
Collaborator

sbc100 commented Dec 30, 2022

Can you explain a little more about what you are trying to do? I guess the idea is that we want make install to work from a source archive?

@MarcusCalhoun-Lopez
Copy link
Contributor Author

Sorry for not being clear.
I am working on getting the latest version emscripten working on the MacPorts project.
For MacPorts ports, it is highly preferred to use source archives instead of using Git.
GitHub provides such source archives, but, of course, they are not Git archives.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comment

@sbc100
Copy link
Collaborator

sbc100 commented Dec 30, 2022

I think you might need to update your branch to get the tests to pass.

@sbc100 sbc100 merged commit ad99d3e into emscripten-core:main Dec 30, 2022
@MarcusCalhoun-Lopez MarcusCalhoun-Lopez deleted the no_git branch December 31, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants