Skip to content

docs: Add docs for stack.h #18877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

waywardmonkeys
Copy link
Contributor

This does not include documentation for emscripten_stack_init() as this appears to be for use internally within emscripten.

@waywardmonkeys
Copy link
Contributor Author

The test that failed here is test_minimal_runtime_code_size_random_printf_wasm which is not related to my changes.

@waywardmonkeys waywardmonkeys force-pushed the add-website-docs-for-stack.h branch from e926c60 to 1018b15 Compare March 2, 2023 05:29
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @sbc100 what do you think?

This does not include documentation for `emscripten_stack_init()`
as this appears to be for use internally within emscripten.
@waywardmonkeys waywardmonkeys force-pushed the add-website-docs-for-stack.h branch from 1018b15 to 13a6bcb Compare March 3, 2023 00:05
@waywardmonkeys
Copy link
Contributor Author

Thanks @Akaricchi! Changes applied.

@kripken kripken merged commit e66f0e7 into emscripten-core:main Mar 3, 2023
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Mar 17, 2023
This does not include documentation for `emscripten_stack_init()`
as this appears to be for use internally within emscripten.
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Mar 17, 2023
This does not include documentation for `emscripten_stack_init()`
as this appears to be for use internally within emscripten.
@waywardmonkeys waywardmonkeys deleted the add-website-docs-for-stack.h branch January 21, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants