Skip to content

Rename internal MINIFY_ASMJS_EXPORT_NAMES setting. NFC #18893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Mar 3, 2023

No description provided.

@sbc100 sbc100 requested a review from kripken March 3, 2023 23:25
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this given MINIFY_WASM_IMPORTS_AND_EXPORTS exists as an internal setting? I suggested in the other PR that we could perhaps make that one public. And maybe then we don't need this one?

@sbc100
Copy link
Collaborator Author

sbc100 commented Mar 3, 2023

Do we need this given MINIFY_WASM_IMPORTS_AND_EXPORTS exists as an internal setting? I suggested in the other PR that we could perhaps make that one public. And maybe then we don't need this one?

This one is separate and only deals with exports, not imports.

See

if settings.MINIFY_WASM_IMPORTS_AND_EXPORTS:
js_file = minify_wasm_imports_and_exports(js_file, wasm_file, minify_whitespace=minify_whitespace, minify_exports=settings.MINIFY_ASMJS_EXPORT_NAMES, debug_info=debug_info)

Perhaps we don't need this distinction. I'll leave that to a separate PR though. I think we can land this now regardless.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@sbc100 sbc100 enabled auto-merge (squash) March 3, 2023 23:47
@sbc100 sbc100 disabled auto-merge March 4, 2023 00:30
@sbc100 sbc100 merged commit 76ef3ad into main Mar 4, 2023
@sbc100 sbc100 deleted the rename_settings branch March 4, 2023 00:30
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Mar 17, 2023
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants