Deprecate allocateUTF8 in favor of stringToNewUTF8
#19089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Mar 29, 2023
| @@ -226,9 +226,9 @@ mergeInto(LibraryManager.library, { | |||
|
|
|||
| // Allocate heap space for a JS string, and write it there. | |||
| // It is the responsibility of the caller to free() that memory. | |||
| $allocateUTF8: function(str) { | |||
| $stringToNewUTF8: function(str) { | |||
There was a problem hiding this comment.
It would probably be good to collect the contents of runtime_strings.js (including the accompanying stringToUTF8) here as well.
There was a problem hiding this comment.
Yes, that is part of our overall goal of moving things from runtime to library functions..
sbc100
added a commit
that referenced
this pull request
Mar 29, 2023
The old name is still available as an alias in library_legacy.js. Followup to #19089
|
Thanks, looks good! |
sbc100
added a commit
that referenced
this pull request
Mar 30, 2023
The old name is still available as an alias in library_legacy.js. Followup to #19089
sbc100
added a commit
that referenced
this pull request
Mar 30, 2023
The old name is still available as an alias in library_legacy.js. Followup to #19089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #19064