Build-time error on use of emscripten_promise_any if Promise.any is not available #19172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
conditional_promise_any
branch
2 times, most recently
from
5f417e5 to
a88ef13
Compare
kripken
reviewed
Apr 13, 2023
test/test_core.py
Outdated
| # This test depends on Promise.any, which in turn requires a modern target. Check that it | ||
| # fails to even build without bumping the min versions: | ||
| err = self.expect_fail([EMCC, test_file('core/test_promise.c')]) | ||
| self.assertContained('error: emscripten_promise_any used, but Promise.any is not supported the current browser configuration', err) |
There was a problem hiding this comment.
Suggested change
| self.assertContained('error: emscripten_promise_any used, but Promise.any is not supported the current browser configuration', err) | |
| self.assertContained('error: emscripten_promise_any used, but Promise.any is not supported in the current runtime configuration (run with EMCC_DEBUG=1 in the env for more details)', err) |
sbc100
force-pushed
the
conditional_promise_any
branch
3 times, most recently
from
47693ab to
5bf1a9e
Compare
kripken
approved these changes
Apr 13, 2023
tlively
reviewed
Apr 13, 2023
| @@ -9761,6 +9761,14 @@ def test_main_reads_args(self): | |||
|
|
|||
| @requires_node | |||
| def test_promise(self): | |||
| # This test depends on Promise.any, which in turn requires a modern target. Check that it | |||
| # fails to even build without bumping the min versions: | |||
| err = self.expect_fail([EMCC, test_file('core/test_promise.c')]) | |||
There was a problem hiding this comment.
Don't all the versions below support Promise.any, so this build should succeed rather than fail? I must be missing something.
There was a problem hiding this comment.
The default versions fail, so we run a compile here to check that it fails, then we set the correct settings and then we expect the test to pass, right?
There was a problem hiding this comment.
Aha, yes, makes sense. I didn't grok that this was doing the build twice, once before and once after setting the settings.
sbc100
force-pushed
the
conditional_promise_any
branch
2 times, most recently
from
1af44c8 to
b40e4fd
Compare
sbc100
force-pushed
the
conditional_promise_any
branch
from
b40e4fd to
bd5dc58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.