You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds nanosecond support for file times in WasmFS, specifically when used for utime and stat. This PR was separated from #19561 (comment), reusing the same tests.
It looks like the diff still contains changes from #19561. If you change the target branch for this PR from main to jameshu15869:library-wasmfs-utime, that would fix the diff. Although it looks like that branch is in your fork, so this probably isn't possible, unfortunately. We'll have to wait until #19561 is merged to get a reasonable diff here.
Ah I see. For this PR, I did git checkout -b on my old (combined) branch before manually undoing the nanosecond changes on #19561. Is there a better way to do this in the future?
One way would be to add a commit undoing the changes on the original PR, then fork a new branch off of it, then revert the undoing of the changes on the new branch so that the revert commit actually reapplies the changes. Then even if the diff for the PR that adds the changes includes everything, we can just look at the diff for that revert commit to see only the new changes.
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm but we have some failures on main it seems, that are showing up here and everywhere else. Work is ongoing to fix those but this will need to wait to land on that.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds nanosecond support for file times in WasmFS, specifically when used for
utimeandstat. This PR was separated from #19561 (comment), reusing the same tests.