Skip to content

Hash-pin workflow dependencies, install dependabot for workflows #19637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

pnacht
Copy link
Contributor

@pnacht pnacht commented Jun 15, 2023

Fixes #19636.

As the issue above describes, hash-pinning workflow dependencies ensures your CI is doing what's expected. And dependabot ensures the Actions remain up-to-date and safely pinned.

pnacht added 3 commits June 15, 2023 17:50
Signed-off-by: Pedro Kaj Kjellerup Nacht <[email protected]>
Signed-off-by: Pedro Kaj Kjellerup Nacht <[email protected]>
@sbc100 sbc100 merged commit 671ea82 into emscripten-core:main Jun 21, 2023
@sbc100
Copy link
Collaborator

sbc100 commented Jun 21, 2023

This update seems to causing the scorecards workflow to fail on main: https://github.com/emscripten-core/emscripten/actions/runs/5336033358. I have no idea how to interpret all that output. Can we revert or fix?

@pnacht
Copy link
Contributor Author

pnacht commented Jun 21, 2023

Ah, that was a change in how Scorecard publishes its results to the public dataset. It now requires id-token: write. I'll send a PR to fix this in a moment!

@pnacht
Copy link
Contributor Author

pnacht commented Jun 21, 2023

Just sent #19674 to fix this issue, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash-pin workflow dependencies and keep them updated
2 participants