Fix -sDETERMINISTIC under node >= 16 #19663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
deterministic
branch
2 times, most recently
from
3cdd7b9 to
c5ef01d
Compare
It turns out you can't override `performance.now` on modern versions of not. Not sure if that is bug, but we have to work around it. This should make the CI green again since we updated emsdk to node 16.
kripken
approved these changes
Jun 21, 2023
|
|
||
| // Setting performance.now to deterministicNow doesn't work so we instead | ||
| // use a helper function in parseTools (getPerformanceNow()) to call it | ||
| // directly. |
There was a problem hiding this comment.
Maybe link to this PR as a source for the issue?
There was a problem hiding this comment.
I'm not sure thats really necessary.. isn't that what git blame is for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out you can't override
performance.nowon modern versions of not. Not sure if that is bug, but we have to work around it.This should make the CI green again since we updated emsdk to node 16.