Skip to content

Reduce limits on test output. NFC #19687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Reduce limits on test output. NFC #19687

merged 1 commit into from
Jun 22, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jun 22, 2023

I noticed the following error on the emscripten-releases bot which makes me thing perhaps we are just writing too much output when certain tests fail:

  File "/b/s/w/ir/x/w/install/emscripten/test/runner.py", line 468, in <module>
    sys.exit(main(sys.argv))
  File "/b/s/w/ir/x/w/install/emscripten/test/runner.py", line 457, in main
    num_failures = run_tests(options, suites)
  File "/b/s/w/ir/x/w/install/emscripten/test/runner.py", line 333, in run_tests
    res = testRunner.run(suite)
  File "/b/s/w/ir/cache/vpython/store/cpython-n8umfpv0s1ufm2q1s4irhb59jc/contents/lib/python3.8/unittest/runner.py", line 183, in run
    result.printErrors()
  File "/b/s/w/ir/cache/vpython/store/cpython-n8umfpv0s1ufm2q1s4irhb59jc/contents/lib/python3.8/unittest/runner.py", line 110, in printErrors
    self.printErrorList('FAIL', self.failures)
  File "/b/s/w/ir/cache/vpython/store/cpython-n8umfpv0s1ufm2q1s4irhb59jc/contents/lib/python3.8/unittest/runner.py", line 117, in printErrorList
    self.stream.writeln("%s" % err)
  File "/b/s/w/ir/cache/vpython/store/cpython-n8umfpv0s1ufm2q1s4irhb59jc/contents/lib/python3.8/unittest/runner.py", line 25, in writeln
    self.write(arg)
BlockingIOError: [Errno 11] write could not complete without blocking

See https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8777566115217933025/+/u/Emscripten_testsuite__UBSan_/stdout

The failing test was generating a lot of output in this case.

I noticed the following error on the emscripten-releases bot which
makes me thing perhaps we are just writing too much output when
certain tests fail:

```
  File "/b/s/w/ir/x/w/install/emscripten/test/runner.py", line 468, in <module>
    sys.exit(main(sys.argv))
  File "/b/s/w/ir/x/w/install/emscripten/test/runner.py", line 457, in main
    num_failures = run_tests(options, suites)
  File "/b/s/w/ir/x/w/install/emscripten/test/runner.py", line 333, in run_tests
    res = testRunner.run(suite)
  File "/b/s/w/ir/cache/vpython/store/cpython-n8umfpv0s1ufm2q1s4irhb59jc/contents/lib/python3.8/unittest/runner.py", line 183, in run
    result.printErrors()
  File "/b/s/w/ir/cache/vpython/store/cpython-n8umfpv0s1ufm2q1s4irhb59jc/contents/lib/python3.8/unittest/runner.py", line 110, in printErrors
    self.printErrorList('FAIL', self.failures)
  File "/b/s/w/ir/cache/vpython/store/cpython-n8umfpv0s1ufm2q1s4irhb59jc/contents/lib/python3.8/unittest/runner.py", line 117, in printErrorList
    self.stream.writeln("%s" % err)
  File "/b/s/w/ir/cache/vpython/store/cpython-n8umfpv0s1ufm2q1s4irhb59jc/contents/lib/python3.8/unittest/runner.py", line 25, in writeln
    self.write(arg)
BlockingIOError: [Errno 11] write could not complete without blocking
```

See https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8777566115217933025/+/u/Emscripten_testsuite__UBSan_/stdout

The failing test was generating a lot of output in this case.
@sbc100 sbc100 requested a review from kripken June 22, 2023 21:21
@sbc100 sbc100 merged commit cfa864b into main Jun 22, 2023
@sbc100 sbc100 deleted the limit_size branch June 22, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants